Repository navigation
Module Manager: ajax DataTable (client/server paradigm) — fixes the filter FOUC - #327
Merged
Merged
Conversation
…ilter FOUC The modules grid server-rendered every row and filtered client-side, so a remembered tab flashed All → the chosen type on load. Refactored to the Tiger datatable paradigm the Users table uses: an EMPTY table fed by System_Service_Modules::datatable over /api (server-side search / type-filter / sort / paginate), column renderers that build the cells + gate the activate/deactivate/delete controls off per-row flags (can_toggle / can_delete), and the chosen type remembered in a cookie the controller reads so the active pill renders server-side and the first ajax load is already filtered — no flash. catalog() is the shared authority (controller pills + the feed). Activate/delete now re-fetch the grid in place (table.ajax.reload) instead of window.location.reload, and the full-catalog counts ride each response so the pills stay accurate. Removes the inline <style> (the desc clamp is an inline style attr in the renderer). Supersedes #326 (tab persistence) — tigerDataTable's stateSave covers sort/page/search for free. Co-Authored-By: Claude Opus 4.8 <[email protected]> Claude-Session: https://claude.ai/code/session_01ASauLLscjqdsNqBNsx2Typ
…table-ajax # Conflicts: # modules/system/controllers/ModulesController.php # modules/system/views/scripts/modules/index.phtml
…digm #327 moved the modules list off server-rendered $this->view->modules onto the System_Service_Modules::datatable /api endpoint, so the old assertion ("the screen builds the on-disk module list") now sees null. Assert the new contract: index dispatches 200 (the shell), and datatable() returns the on-disk rows with active/protected/source + system flagged protected. Also covers datatable(). Co-Authored-By: Claude Opus 4.8 <[email protected]> Claude-Session: https://claude.ai/code/session_01ASauLLscjqdsNqBNsx2Typ
…dispatch test Co-Authored-By: Claude Opus 4.8 <[email protected]> Claude-Session: https://claude.ai/code/session_01ASauLLscjqdsNqBNsx2Typ
WebTigers
added a commit
that referenced
this pull request
Oct 10, 2026
…ode landed) (#336) TIGER-225 (atomic composer self-update) and #327 (ajax DataTable) merged code that is legitimately hard to unit-cover — the composer-swap path is the documented destructive boundary (never run in CI) and the DataTable rows are client-side JS. The achievable ceiling dropped to ~71.5%, so the 72% floor now sits ABOVE it and reddens main's coverage job on every push/PR. Lower the floor to 71 so it's a real floor again (still catches genuine regressions); ratchet back up as that code gets test-harness coverage. Claude-Session: https://claude.ai/code/session_01ASauLLscjqdsNqBNsx2Typ Co-authored-by: Claude Opus 4.8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Refactors the Module Manager grid from server-rendered rows + client-side filtering to the Tiger
DataTables paradigm (WEBSERVICES §5), the same shape the Users table uses: an empty
<table>fed bySystem_Service_Modules::datatableover/api, with server-side search / type-filter / sort / paginateand client column renderers that gate controls off per-row ACL flags.
Why
The old screen rendered all rows server-side and filtered them client-side, so a remembered tab flashed
All → the chosen type on load (the FOUC Beau reported). Fetching rows already-filtered removes the
flash at the source.
How the FOUC goes away
active, soextraDatasends that type on the first ajax load — the grid loads already filtered(just the normal processing spinner, never a wrong-filter flash).
catalog()is the one authority for the module list (controller builds the pills + counts from it; thedatatable feed filters/sorts/paginates it).
drawCallbackkeeps the pill badgesaccurate after an activate / delete with no page reload.
Also
table.ajax.reload) instead ofwindow.location.reload()— answering the earlier "why reload at all?" (the sidebar nav for anewly-active module still updates on next navigation; that's the one accepted trade).
<style>block (the 2-line description clamp is now an inlinestyle=attr in therenderer).
tigerDataTable's built-instateSaveremembers sort / page / length / search for free.Supersedes #326 (localStorage tab persistence) — closed in favour of this.
Verified on dev
catalog()→ 36 modules, counts{plugin:17, app:12, developer:2, theme:4, sdk:1}.datatable(type=theme)→ result 1, total 36, filtered 4, page 4; row carriestype_label,type_icon,source,active,is_theme,can_toggle,can_delete,is_default; counts echoed.search=grey→ filtered 1 →theme-grey-mist. ACL gate enforced (superadmin only).🤖 Generated with Claude Code
https://claude.ai/code/session_01ASauLLscjqdsNqBNsx2Typ